-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move lit tests so no symlink is needed #4615
Move lit tests so no symlink is needed #4615
Conversation
Great idea! Having trouble browsing/commenting on specific files since GitHub only loads the first 3000 files and my browser keeps hanging. :) I'll just make comments here instead:
|
@robin-aws could you review the current diff? I think it addresses your comments. I've excluded the actual move for now since it's easier to review and then the PR doesn't accrue conflicts. Once you approve it I'll do the actual move, reapprove, and then merge. |
Looks great and sounds like a plan, thanks! :) |
dce574a
to
620ad15
Compare
b5d5cef
to
42fd041
Compare
Move Littish tests from `Test` to `Source/IntegrationTests/Test`. This way there's no symlink needed which causes Rider to behave annoyingly <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Recently (#4615), the Dafny test suite moved from `Test/` to `Source/IntegrationTests/TestFiles/LitTests/LitTest/`. This PR makes a corresponding change in the `respositoryRoot` definition in `lit.site.cfg`. This allows `lit` to be run in the new location. <small>By submitting this pull request, I confirm that my contribution is made under the terms of the [MIT license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
Changes
Move Littish tests from
Test
toSource/IntegrationTests/Test
. This way there's no symlink needed which causes Rider to behave annoyinglyBy submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.